Skip to content

perf(render): back wall slots with a fixed array#87

Merged
TypeThe0ry merged 1 commit into
devfrom
codex/perf-layout-wall-array
Jul 16, 2026
Merged

perf(render): back wall slots with a fixed array#87
TypeThe0ry merged 1 commit into
devfrom
codex/perf-layout-wall-array

Conversation

@TypeThe0ry

@TypeThe0ry TypeThe0ry commented Jul 16, 2026

Copy link
Copy Markdown
Member

Summary

  • replace growable wall-slot buffers with fixed-size array-backed lists for RIICHI, GB, and SICHUAN
  • remove per-layout null-fill loops and the second ArrayList/backing-array copy
  • retain fixed size, null slots, encounter order, RandomAccess behavior, and external immutability

Validation

  • intentionally not run locally
  • GitHub Actions owns cross-platform correctness and the protected performance-layout A/B profile added in perf: benchmark complete table layouts #86
  • per the current integration-first policy, ordinary CI gates the merge; a protected FAIL_REGRESSION_OR_BEHAVIOR result will trigger a dedicated revert PR

@TypeThe0ry TypeThe0ry added performance-ab Run the base-owned paired performance gate performance-layout Use the all-variant table layout performance profile labels Jul 16, 2026 — with ChatGPT Codex Connector
@TypeThe0ry ChatGPT Codex Connector

TypeThe0ry commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

The zero-duration failed decide check from run 29496780934 is a superseded label-order event: it observed performance-ab before the profile label was visible and correctly rejected the incomplete label set. The valid protected performance-layout A/B run is 29496781164 and has both labels. Ordinary CI and that valid run remain authoritative.

@TypeThe0ry
TypeThe0ry merged commit fcc0df7 into dev Jul 16, 2026
14 of 16 checks passed
@TypeThe0ry ChatGPT Codex Connector

TypeThe0ry commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

Post-merge protected layout A/B completed in run https://github.com/EllanServer/MahjongEngine/actions/runs/29496781164. The protected decision is INCONCLUSIVE_NOISE_OR_NO_GAIN, not FAIL_REGRESSION_OR_BEHAVIOR. Under the integration-first policy the fixed-array wall-slot implementation remains merged; no revert is warranted.

@Arbousier1
Arbousier1 deleted the codex/perf-layout-wall-array branch July 16, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

performance-ab Run the base-owned paired performance gate performance-layout Use the all-variant table layout performance profile

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TypeThe0ry @Arbousier1